Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S slixmpp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • poeziopoezio
  • slixmpp
  • Merge requests
  • !225

Add public names in all

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicoco K requested to merge nicoco/slixmpp:add-public-names-in-_all_ into master Nov 22, 2022
  • Overview 0
  • Commits 2
  • Pipelines 2
  • Changes 2

A very small change, but some linters (such as pycharm) rightfully raise a warning when a module has an __all__ attribute and you import something not in __all__.

I believe these 2 names are meant to be imported so it makes sense to have them in __all__.

(I like when there is no warning, we're not doing C++ where we expect to ignore 157957 warnings on every build ^^)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: add-public-names-in-_all_