Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S slixmpp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • poeziopoezio
  • slixmpp
  • Merge requests
  • !220

logger: remove NullHandler for the "slixmpp" handler

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicoco K requested to merge nicoco/slixmpp:restore-stringprep-warning into master Oct 03, 2022
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

This does not seem to accomplish anything besides hiding the "using the slow, pure python stringprep" warning, unless you import logging and add another handler before to the "slixmpp" logger BEFORE importing slixmpp.

import logging

logging.getLogger("slixmpp").addHandler(logging.StreamHandler())

from slixmpp import ...

I may have failed to understand if this accomplishes something else, but I think this was a workaround to get rid of warning in some old python versions that aren't supported now anyway.

Hiding the stringprep warning by default defeats the point of having a warning in the first place IMHO.

Edited Oct 03, 2022 by Nicoco K
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: restore-stringprep-warning