Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S slixmpp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • poeziopoezio
  • slixmpp
  • Merge requests
  • !212

Use gethostbyname when using aiodns

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dunedan requested to merge Dunedan/slixmpp:aiodns-gethostbyname into master Jul 31, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

Slixmpp behaves differently when resolving host names, whether aiodns is used or not. With aiodns only DNS is used, while without asyncio.loop.getaddrinfo() is used instead, which utilizes the Name Service Switch (NSS) to resolve host names by other means (hosts-file, mDNS, ...) as well.

To unify the behavior, this replaces the use of aiodns.DNSResolver().query() with aiodns.DNSResolver().gethostbyname(). This makes the behavior resolving host names more consistent between using aiodns or not, as both now honor the NSS configuration and removes the need for the previously existing workaround to resolve localhost.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: aiodns-gethostbyname