Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S slixmpp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • poeziopoezio
  • slixmpp
  • Merge requests
  • !207

XEP-0363: Fix upload service auto discovery for components

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicoco K requested to merge nicoco/slixmpp:xep0363-as-component into master Jun 18, 2022
  • Overview 4
  • Commits 4
  • Pipelines 3
  • Changes 1

I identified 2 problems, when using this as a component

First, instead of requesting the server's disco items and features, the upload service searches for items in the component itself. Maybe this should be fixed in xep_0030.get_info_from_domain but this plugin is quite complex and I don't feel confident modifying anything in it.

Secondly, the info['disco_info']['identities'] of the component is an empty string, raising an exception at the line for identity in info['disco_info']['identities']:. This might be due to a (silent) misuse of xep_0030.add_identity in xep_0100

All in all, these fixes are required for slidge to work, but maybe they are not in the right place.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: xep0363-as-component