Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S slixmpp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 37
    • Issues 37
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • poeziopoezio
  • slixmpp
  • Merge requests
  • !198

xep_0030: allow extra args in get_info_from_domain

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed ninjatrappeur requested to merge ninjatrappeur/slixmpp:nin/fix-getinfofromdomainkwargs into master Apr 22, 2022
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 2

Aftermath of ea2d851a.

http_upload from xep_0363 is now forwarding all its extra input args to get_info_from_domain. Sadly for us, get_info_from_domain won't accept any extra args passed that way and will instead yield a "got an unexpected keyword argument" exception on runtime.

Modifying get_info_from_domain to accept these extra args.

I hit this bug by passing a timeout_callback argument to http_upload. Adding this scenario to the relevant integration test.

Note: I hit this bug in a NixOS test. This patch does fix my bug, I however did not manage to run the integration test, I hope I did not screw up there :o)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nin/fix-getinfofromdomainkwargs