Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • biboumi biboumi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value stream
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • louiz’
  • biboumibiboumi
  • Issues
  • #3418

Closed
Open
Created Jan 20, 2020 by ge0rg@ge0rg

Lack of libidn silently breaks `jidprep()` and MUC occupant JIDs

The dependency on libidn is a soft one, however, the jidprep() function won't work if libidn isn't there (it will return "" instead of the prepped string).

This function is currently only used in XmppComponent::send_user_join() where it will make the jid attribute of MUC occupant elememnts vanish.

This is a ticking time bomb, waiting to create impossible-to-debug corner cases in your codebase.

Please do one of these:

  1. get rid of jidprep() altogether
  2. make jidprep() return the original string, which is slightly less bad than "".
  3. make libidn a hard requirement
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking