Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
biboumi
biboumi
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 88
    • Issues 88
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 7
    • Merge Requests 7
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • louiz’
  • biboumibiboumi
  • Issues
  • #3418

Closed
Open
Opened Jan 20, 2020 by ge0rg@ge0rg

Lack of libidn silently breaks `jidprep()` and MUC occupant JIDs

The dependency on libidn is a soft one, however, the jidprep() function won't work if libidn isn't there (it will return "" instead of the prepped string).

This function is currently only used in XmppComponent::send_user_join() where it will make the jid attribute of MUC occupant elememnts vanish.

This is a ticking time bomb, waiting to create impossible-to-debug corner cases in your codebase.

Please do one of these:

  1. get rid of jidprep() altogether
  2. make jidprep() return the original string, which is slightly less bad than "".
  3. make libidn a hard requirement
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: louiz/biboumi#3418