Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
biboumi
biboumi
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 88
    • Issues 88
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 7
    • Merge Requests 7
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • louiz’
  • biboumibiboumi
  • Issues
  • #3396

Closed
Open
Opened Dec 11, 2018 by ge0rg@ge0rg

No conversion of `333` timestamp into <delay> element

When parsing the 333 response in IrcClient::on_topic_who_time_received, the author is extracted but the timestamp is ignored.

It is a good practice to add a XEP-0203 <delay> element with the timestamp to the subject, so it can be displayed accordingly by the client.

Example (what you receive from the IRC server):

>> :adams.freenode.net 332 Ge0rG #aprsdroid :APRSdroid 1.5.0 +++ Feel free to stay online some hours after asking your question, or leave your e-mail address +++ https://play.google.com/store/apps/details?id=org.aprsdroid.app +++ APK: http://aprsdroid.org/get +++ Passcode: http://aprsdroid.org/passcode/ +++ Home: http://aprsdroid.org/
>> :adams.freenode.net 333 Ge0rG #aprsdroid Ge0rG!~georg@yaxim.boerde.de 1542886601

What biboumi makes out of it:

<message id="35c10abe-f26d-4f9c-95f7-69471dc1cd18-254" to="georg@yax.im/poezio-IS8H" type="groupchat" 
      from="#aprsdroid%freenode@irc.yax.im/Ge0rG">
  <subject>APRSdroid 1.5.0 +++ Feel free to stay online some hours after asking your question, or leave
      your e-mail address +++ https://play.google.com/store/apps/details?id=org.aprsdroid.app +++ APK:
      http://aprsdroid.org/get +++ Passcode: http://aprsdroid.org/passcode/ +++ Home: http://aprsdroid.org/</subject>
</message>

The 1542886601 timestamp should be translated into a <delay> element.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: louiz/biboumi#3396