Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
biboumi
biboumi
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 88
    • Issues 88
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 7
    • Merge Requests 7
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • louiz’
  • biboumibiboumi
  • Issues
  • #3367

Closed
Open
Opened Jul 23, 2018 by Jonas Schäfer@horazontContributor

More user-friendly text on Ad-Hoc config options

The data form for channel configuration looks like this:

  <command xmlns="http://jabber.org/protocol/commands" status="executing" node="configure" sessionid="1342523a-0c6a-484d-ba9e-1ca2b3075a8b">
    <x xmlns="jabber:x:data" type="form">
      <field type="list-single" label="Record history for this channel" var="record_history" desc="If unset, the value is the one configured globally">
        <value>true</value>
        <option label="unset">
          <value>unset</value>
        </option>
        <option label="true">
          <value>true</value>
        </option>
        <option label="false">
          <value>false</value>
        </option>
      </field>
      <field type="text-single" label="Out encoding" var="encoding_out" desc="The encoding used when sending messages to the IRC server. Defaults to the server's \xe2\x80\x9cout encoding\xe2\x80\x9d if unset for the channel">
        <value>ISO-8859-1</value>
      </field>
      <field type="text-single" label="In encoding" var="encoding_in" desc="The encoding used to decode message received from the IRC server. Defaults to the server's \xe2\x80\x9cin encoding\xe2\x80\x9d if unset for the channel">
        <value>ISO-8859-1</value>
      </field>
      <field type="boolean" label="Persistent" var="persistent" desc="If set to true, when all XMPP clients have left this channel, biboumi will stay idle in it, without sending a PART command.">
        <value>true</value>
      </field>
      <instructions>Edit the form, to configure the settings of the IRC channel #delphigl</instructions>
      <title>Configure the IRC channel #delphigl on server irc.euirc.net</title>
    </x>
    <actions>
      <next/>
    </actions>
  </command>

The options for the record_history variable could use more human-friendly names. I suggest:

  • unset: "Server default (" + labels[the_actual_default] + ")"
  • true (= labels[true]): Enabled
  • false (= labels[false]): Disabled

The persistent field tooltip should talk about "enabled" and "disabled" instead of "true" and "false".

(I addressed the incorrect syntax for the field description in !31.)

Edited Jul 27, 2018 by louiz’
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: louiz/biboumi#3367