Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
biboumi
biboumi
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 88
    • Issues 88
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 7
    • Merge Requests 7
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • louiz’
  • biboumibiboumi
  • Issues
  • #3343

Closed
Open
Opened Mar 19, 2018 by louiz’@louizMaintainer

MAM: “after” is broken because it relies on the id_ ordering

If, for some reason, the id_ field of the history does not represent the actual chronological ordering (if you imported old archives, for examples), then any request containing a “after” field will return wrong results.

We should stop relying on the id_ ordering, and instead use only the date_ column. However, we currently only store INTEGERs, and that’s not precise (only to the second) enough for proper ordering if messages are received in a short interval.

I could convert the INTEGER dates into proper datetime (postgresql) or real (sqlite) which have a very high precision (like milliseconds), and use only that to order archives.

What do you think?

Edited Mar 19, 2018 by louiz’
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
8.0
Milestone
8.0
Assign milestone
Time tracking
None
Due date
None
Reference: louiz/biboumi#3343