Commit f7e4adb1 authored by louiz’'s avatar louiz’

Avoid any potential int overflow

parent c046d2ea
......@@ -200,7 +200,11 @@ int Poller::poll(const std::chrono::milliseconds& timeout)
// Unblock all signals, only during the epoll_pwait call
sigset_t empty_signal_set{};
const int nb_events = ::epoll_pwait(this->epfd, revents, max_events, timeout.count(),
int real_timeout = std::numeric_limits<int>::max();
if (timeout.count() < real_timeout) // Just avoid any potential int overflow
real_timeout = static_cast<int>(timeout.count());
const int nb_events = ::epoll_pwait(this->epfd, revents, max_events, real_timeout,
if (nb_events == -1)
......@@ -227,9 +227,10 @@ void TCPSocketHandler::consume_in_buffer(const std::size_t size)
void TCPSocketHandler::start_tls(const std::string& address, const std::string& port)
void TCPSocketHandler::start_tls(const std::string& address, const std::string& port_string)
Botan::TLS::Server_Information server_info(address, "irc", std::stoul(port));
auto port = std::min(std::stoul(port_string), static_cast<unsigned long>(std::numeric_limits<uint16_t>::max()));
Botan::TLS::Server_Information server_info(address, "irc", static_cast<uint16_t>(port));
auto policy_directory = Config::get("policy_directory", utils::dirname(Config::get_filename()));
if (!policy_directory.empty() && policy_directory[policy_directory.size()-1] != '/')
policy_directory += '/';
......@@ -112,17 +112,20 @@ void XmppComponent::on_connection_close(const std::string& error)
void XmppComponent::parse_in_buffer(const size_t size)
// in_buf.size, or size, cannot be bigger than our read-size (4096) so it’s safe
// to cast.
if (!this->in_buf.empty())
{ // This may happen if the parser could not allocate enough space for
// us. We try to feed it the data that was read into our in_buf
// instead. If this fails again we are in trouble.
this->parser.feed(this->, this->in_buf.size(), false);
this->parser.feed(this->, static_cast<int>(this->in_buf.size()), false);
{ // Just tell the parser to parse the data that was placed into the
// buffer it provided to us with GetBuffer
this->parser.parse(size, false);
this->parser.parse(static_cast<int>(size), false);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment