Commit c3313d0d authored by louiz’'s avatar louiz’

Always free the PGresult pointer returned by PQexec

Fix a somewhat big memory leak
parent 24dc05dd
#include <biboumi.h>
#ifdef PQ_FOUND
#include <utils/scopeguard.hpp>
#include <database/postgresql_engine.hpp>
#include <database/postgresql_statement.hpp>
......@@ -53,6 +55,10 @@ std::tuple<bool, std::string> PostgresqlEngine::raw_exec(const std::string& quer
{
log_debug("raw_exec:", query);
PGresult* res = PQexec(this->conn, query.data());
auto sg = utils::make_scope_guard([res](){
PQclear(res);
});
auto res_status = PQresultStatus(res);
if (res_status != PGRES_COMMAND_OK)
return std::make_tuple(false, PQresultErrorMessage(res));
......
......@@ -14,7 +14,10 @@ class PostgresqlStatement: public Statement
conn(conn)
{}
~PostgresqlStatement()
{}
{
PQclear(this->result);
this->result = nullptr;
}
PostgresqlStatement(const PostgresqlStatement&) = delete;
PostgresqlStatement& operator=(const PostgresqlStatement&) = delete;
PostgresqlStatement(PostgresqlStatement&& other) = delete;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment