Commit 8a912ea3 authored by louiz’'s avatar louiz’

Apply a few clang-tidy cppcoreguidelines-* fixes

parent 0dfeb5a9
...@@ -99,7 +99,7 @@ int main(int ac, char** av) ...@@ -99,7 +99,7 @@ int main(int ac, char** av)
// Block the signals we want to manage. They will be unblocked only during // Block the signals we want to manage. They will be unblocked only during
// the epoll_pwait or ppoll calls. This avoids some race conditions, // the epoll_pwait or ppoll calls. This avoids some race conditions,
// explained in man 2 pselect on linux // explained in man 2 pselect on linux
sigset_t mask; sigset_t mask{};
sigemptyset(&mask); sigemptyset(&mask);
sigaddset(&mask, SIGINT); sigaddset(&mask, SIGINT);
sigaddset(&mask, SIGTERM); sigaddset(&mask, SIGTERM);
......
...@@ -198,7 +198,7 @@ int Poller::poll(const std::chrono::milliseconds& timeout) ...@@ -198,7 +198,7 @@ int Poller::poll(const std::chrono::milliseconds& timeout)
static const size_t max_events = 12; static const size_t max_events = 12;
struct epoll_event revents[max_events]; struct epoll_event revents[max_events];
// Unblock all signals, only during the epoll_pwait call // Unblock all signals, only during the epoll_pwait call
sigset_t empty_signal_set; sigset_t empty_signal_set{};
sigemptyset(&empty_signal_set); sigemptyset(&empty_signal_set);
const int nb_events = ::epoll_pwait(this->epfd, revents, max_events, timeout.count(), const int nb_events = ::epoll_pwait(this->epfd, revents, max_events, timeout.count(),
&empty_signal_set); &empty_signal_set);
......
...@@ -35,7 +35,7 @@ void TCPClientSocketHandler::init_socket(const struct addrinfo* rp) ...@@ -35,7 +35,7 @@ void TCPClientSocketHandler::init_socket(const struct addrinfo* rp)
// Convert the address from string format to a sockaddr that can be // Convert the address from string format to a sockaddr that can be
// used in bind() // used in bind()
struct addrinfo* result; struct addrinfo* result;
struct addrinfo hints; struct addrinfo hints{};
memset(&hints, 0, sizeof(hints)); memset(&hints, 0, sizeof(hints));
hints.ai_flags = AI_NUMERICHOST; hints.ai_flags = AI_NUMERICHOST;
hints.ai_family = AF_UNSPEC; hints.ai_family = AF_UNSPEC;
...@@ -161,14 +161,14 @@ void TCPClientSocketHandler::connect(const std::string& address, const std::stri ...@@ -161,14 +161,14 @@ void TCPClientSocketHandler::connect(const std::string& address, const std::stri
this->local_port = static_cast<uint16_t>(-1); this->local_port = static_cast<uint16_t>(-1);
if (rp->ai_family == AF_INET6) if (rp->ai_family == AF_INET6)
{ {
struct sockaddr_in6 a; struct sockaddr_in6 a{};
socklen_t l = sizeof(a); socklen_t l = sizeof(a);
if (::getsockname(this->socket, (struct sockaddr*)&a, &l) != -1) if (::getsockname(this->socket, (struct sockaddr*)&a, &l) != -1)
this->local_port = ntohs(a.sin6_port); this->local_port = ntohs(a.sin6_port);
} }
else if (rp->ai_family == AF_INET) else if (rp->ai_family == AF_INET)
{ {
struct sockaddr_in a; struct sockaddr_in a{};
socklen_t l = sizeof(a); socklen_t l = sizeof(a);
if (::getsockname(this->socket, (struct sockaddr*)&a, &l) != -1) if (::getsockname(this->socket, (struct sockaddr*)&a, &l) != -1)
this->local_port = ntohs(a.sin_port); this->local_port = ntohs(a.sin_port);
......
...@@ -9,7 +9,7 @@ namespace utils ...@@ -9,7 +9,7 @@ namespace utils
{ {
std::string get_system_name() std::string get_system_name()
{ {
struct utsname uts; struct utsname uts{};
const int res = ::uname(&uts); const int res = ::uname(&uts);
if (res == -1) if (res == -1)
{ {
......
...@@ -106,7 +106,7 @@ private: ...@@ -106,7 +106,7 @@ private:
/** /**
* Expat structure. * Expat structure.
*/ */
XML_Parser parser; XML_Parser parser{};
/** /**
* The current depth in the XML document * The current depth in the XML document
*/ */
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment